-
Notifications
You must be signed in to change notification settings - Fork 217
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add Qwen2-VL static generation #1512
base: main
Are you sure you want to change the base?
Conversation
The pipeline test will not pass until optimum-habana matches the latest changes in transformers huggingface/transformers#34769, namely the task name |
Are you saying we need transformer4.47 for this to work or can you update the examples/images-to-text/run_pipeline to support both cases? |
@tthakkal Could you also review this please. THanks. |
Yes. An update to latest transformers is needed here. |
Hello, with some small fixes, now the example can be run with following command under transformers 4.45.2 (current optimum-habana compatible version)
Kindly review this at your convenience. Thank you! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please add/update relevant test(s) for new model: https://github.com/huggingface/optimum-habana/blob/main/tests/test_image_to_text_example.py
Hi @vidyasiv @jiminha , I have added the tests and README, tested the Qwen2-VL-7b and Qwen2-VL-2b with Please review at your convenience. Thank you! :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @Spycsh for adding tests
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lgtm (only reviewed from test perspective), approving to remove request changes
What does this PR do?
Add Qwen2-VL static generation.
Before submitting